[CodeHealth] Fix clang-tidy warnings part 5#3506
Merged
marcalff merged 4 commits intoopen-telemetry:mainfrom Jul 1, 2025
Merged
[CodeHealth] Fix clang-tidy warnings part 5#3506marcalff merged 4 commits intoopen-telemetry:mainfrom
marcalff merged 4 commits intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3506 +/- ##
=======================================
Coverage 89.96% 89.96%
=======================================
Files 219 219
Lines 7051 7051
=======================================
Hits 6343 6343
Misses 708 708 🚀 New features to boost your workflow:
|
Member
|
According to CI, this solves only 1 warning (85 instead of 86). To reevaluate once part 4 is merged. |
Member
Author
Yes. It may be due to using an older version of clang-tidy in CI. So we won't see the satisfying drop in warnings from this but they do need to be fixed. :) I found the warnings using the clangd extension to vscode while fixing the slicing warning. CI only reports the slicing warning for some reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #2053
Changes
Fixes clang-tidy warnings with the OTLP File component
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes